global $option should be refactored - Joomla! Forum - community, help and support

-

hi, trying figure out, how mvc works, i've noticed dangerous global variable: $option, defined in index.php:

code: select all

$option = jrequest::getcmd('option');

i think it's dangerous , needs refactoring due these reasons:
- local variable same name: '$option' - used in more, thousand places in joomla core
- in places of code see duplication of above global variable: same assignment, above, local variable.

i suggest, quick fix, add $option public variable $mainframe (i.e. japplication class), usage of global variable clear visible , we'll rid of global variable, used in not many, in important places (e.g. in mvc core - don't this...):

code: select all

global $mainframe;
 ... $mainframe->option ...

a suggestion, leave future version. primary reason variable still available in global scope backwards compatibility 1.0 components , current 1.5 components. changing require quite lot of testing across whole codebase.





Comments

Post a Comment

Popular posts from this blog

Flip address is out of range arduino uno r3

-
hello  guy, trying flash firmware on arduino uno rev3 atmega 16u2 using atmel flip. whenever try , import .hex file program, throws error " address out of range ." have looked around online , haven't found solution. , info helpful. here hex file : https://github.com/nicohood/hoodloader2/blob/master/avr/bootloaders/hexfiles/hoodloader2_0_5_uno_atmega16u2.hex its using arduino uno hid Arduino Forum > Using Arduino > Installation & Troubleshooting > Flip address is out of range arduino uno r3 arduino
Read more

Arduino DUE ADC to DAC Piezo 30 Khz-100Khz

-
i working on project providing echo response ultrasonic sensors. piezo facing opposite ultrasonic sensor,with foam material in between damp ultrasonic signal reflecting sensor. event based,read piezo signal[(+) --> a0,(-) --> gnd on arduino due] , after delay(5 ms) drive same piezo through dac0 [(+)---> dac0,(-)--> gnd) so ultrasonic sensor receives signal (30 khz-100 khz) after delay,thereby calculating distance after time of flight of 5 ms. int in_adc0,out_dac0;  //variables adc,dac values (adc0, dac0) void setup() {   //adc configuration   adc->adc_mr |= 0x80;   // dac in free running mode.   adc->adc_cr=2;         // starts adc conversion.   adc->adc_cher=0x80;  // enable adc channels 0     analogreadresolution(12);  analogwriteresolution(12);   //dac configuration   analogwrite(dac0,0);  // enables dac0   serial.begin(9600); }   void loop() { ...
Read more

Indesign and MathType fonts

-
i having trouble getting indesign recognize mathtype fonts.  have been told move mathtype fonts on 2 indesign font folder.  copied mt-extra font file mathtype folder , pasted indesign font folder.  nothing changed.  indesign still gives me blank box after copy mt-extra font mathtype -->illustrator-->indesign.   guess need instructions on how transfer of fonts done correctly.  i'v looked @ install fonts manual indesign, not clear me on how it.  need utility fontexplorer this, or there other way.  what's weird working fine until had reinstall osx , reinstall cs3, font trouble started.  need toggle "activate-reactivate' adobe cs3 , don't know how close 20 max on this, worried that.  (i suspect because of note on forum might necessary).  thoughts appreciated. i'm using windows, advice may worth nothing...   1) shouldn't have deactivate id recognize fonts. 2) design science gives fonts away in type 1 , truetype flavors....
Read more